TF-3348 Move access token from persistent to memory #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tddang-linagora
temporarily deployed
to
PR-3404
GitHub Actions
Inactive
dab246
reviewed
Jan 7, 2025
dab246
reviewed
Jan 7, 2025
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3404. |
dab246
reviewed
Jan 7, 2025
dab246
reviewed
Jan 7, 2025
|
tddang-linagora
temporarily deployed
to
PR-3404
GitHub Actions
Inactive
Screen.Recording.2025-01-07.at.15.12.51.mov
Screen.Recording.2025-01-07.at.15.21.50.mov |
|
Unit test will suffice. |
dab246
reviewed
Jan 7, 2025
lib/features/login/data/local/web_token_oidc_cache_manager.dart
Outdated
Show resolved
Hide resolved
Token refreshed fine Screen.Recording.2025-01-07.at.16.33.04.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Demo
Should not refresh token if token is still valid and browser is refresh
Screen.Recording.2025-01-07.at.10.50.20.mov
Should not force user to login and refresh token if refresh token is still valid and new tab is open
Screen.Recording.2025-01-07.at.10.50.57.mov