Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-3406 Edit as new email #3412

Open
wants to merge 4 commits into
base: master-candidate
Choose a base branch
from
Open

TF-3406 Edit as new email #3412

wants to merge 4 commits into from

Conversation

tddang-linagora
Copy link
Contributor

Issue

Demo

Web

Screen.Recording.2025-01-08.at.15.36.27.mov

Mobile

edit-as-new-email.webm

@tddang-linagora tddang-linagora self-assigned this Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

This PR has been deployed to https://linagora.github.io/tmail-flutter/3412.

@chibenwa
Copy link
Member

chibenwa commented Jan 8, 2025

Can you please make the Edit as new mail being the default action when I open an item in the Template mailbox?

(Here or in a follow up issue)

@tddang-linagora
Copy link
Contributor Author

Can you please make the Edit as new mail being the default action when I open an item in the Template mailbox?

Okay so how can the user view those emails in "Template"?

@chibenwa
Copy link
Member

chibenwa commented Jan 8, 2025

Okay so how can the user view those emails in "Template"?

He don't view them.

It works kind of like the draft mailbox...

@tddang-linagora
Copy link
Contributor Author

Can you please make the Edit as new mail being the default action when I open an item in the Template mailbox?

Done

Screen.Recording.2025-01-08.at.19.53.57.mov

dab246
dab246 reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment •
edited by tddang-linagora
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • IMO, No need to Edit as new email in draft folder @hoangdat
Screen.Recording.2025-01-09.at.09.14.47.mov

lib/features/thread/presentation/thread_view.dart Outdated Show resolved Hide resolved
lib/features/search/email/presentation/search_email_view.dart Outdated Show resolved Hide resolved
lib/features/thread/presentation/thread_view.dart Outdated Show resolved Hide resolved
lib/main/localizations/app_localizations.dart Show resolved Hide resolved
@tddang-linagora
Copy link
Contributor Author

IMO, No need to Edit as new email in draft folder

Screen.Recording.2025-01-09.at.09.42.51.mov

@tddang-linagora tddang-linagora requested a review from dab246 January 9, 2025 10:33
dab246
dab246 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Please rebase it

@chibenwa
Copy link
Member

chibenwa commented Jan 9, 2025 •
edited
Loading

(protip: or just merge a squashed version of it)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dab246 dab246 dab246 approved these changes

@hoangdat hoangdat Awaiting requested review from hoangdat

Assignees

@tddang-linagora tddang-linagora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tddang-linagora @chibenwa @dab246