Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky XdsMemberPermissionTest #1083

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix flaky XdsMemberPermissionTest #1083

wants to merge 1 commit into from

Conversation

Sabadon
Copy link

@Sabadon Sabadon commented Dec 31, 2024

Motivation:
Fix flaky test XdsMemberPermissionTest. See #1077

Modifications:
Added waiting for changes in access rights using await().untilAsserted();

Result:
Less flakiness

@CLAassistant
Copy link

CLAassistant commented Dec 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

minwoox
minwoox approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ikhoon
ikhoon approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself seems good.
Are you considering adapting Central Dogma?

@Sabadon
Copy link
Author

Sabadon commented Jan 3, 2025

Are you considering adapting Central Dogma?

I'm not quiet sure what you mean by "adapting". But I don't use Central Dogma in any of my projects, I'm just interested in contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minwoox minwoox minwoox approved these changes

@jrhee17 jrhee17 jrhee17 approved these changes

@ikhoon ikhoon ikhoon approved these changes

@trustin trustin Awaiting requested review from trustin trustin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sabadon @CLAassistant @ikhoon @jrhee17 @minwoox