Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition waiting for rounds. #3099

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

afck
Copy link
Contributor

@afck afck commented Jan 8, 2025

Motivation

test_end_to_end_listen_for_new_rounds::storage_test_service_grpc is flaky for me locally and sometimes hangs, even though it seems fine on CI.

The logs suggest that the two clients are both waiting for round notifications forever, even though one of them should be the leader in the current round.

Proposal

Adding an explicit prepare_chain fixes the issue.

It's not quite clear why this is necessary, so I created #3100.

Test Plan

Running the test in a loop locally failed quite often. With this change it passed 50 times in a row.

Release Plan

  • Nothing to do / These changes follow the usual release cycle.

Links

@afck afck merged commit b9c5fcd into linera-io:main Jan 8, 2025
21 checks passed
@afck afck deleted the prepare-chain branch January 8, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants