-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added logging request city and request country using geoip2 #38
base: master
Are you sure you want to change the base?
Conversation
From Django Geolocation with GeoIP2 Instructions on how to enable location logging
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to keep the coverage up, could we also some some unit tests to cover the additional 2 new fields.
See the tests/test_models.py
and test/test_mixins.py
.
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.22%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
I added unit tests to cover the 2 new fields: |
#8
Added request city and country logging using Django's wrapper for the python pacakge
geoip2