Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time-based One Time Passwords #256

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

jasonehines
Copy link

This is working. I've tried to document things but I'm not really familiar with restructuredtext, so I may have missed something.

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a379fa0). Click here to learn what that means.
The diff coverage is 43.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #256   +/-   ##
=========================================
  Coverage          ?   85.66%           
=========================================
  Files             ?       26           
  Lines             ?     1605           
  Branches          ?        0           
=========================================
  Hits              ?     1375           
  Misses            ?      230           
  Partials          ?        0
Impacted Files Coverage Δ
flask_user/user_manager__settings.py 100% <100%> (ø)
flask_user/forms.py 98.21% <100%> (ø)
flask_user/db_manager.py 87.69% <100%> (ø)
flask_user/__init__.py 100% <100%> (ø)
flask_user/user_manager__views.py 77.6% <13.09%> (ø)
flask_user/totp_manager.py 47.82% <47.82%> (ø)
flask_user/user_manager__utils.py 87.87% <60%> (ø)
flask_user/user_manager.py 88.83% <69.56%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a379fa0...a59e690. Read the comment docs.

@jasonehines
Copy link
Author

I haven't written test before, so it might be awhile before I can add them.

@abirke
Copy link

abirke commented Jan 26, 2019

I think it's a great idea to implement 2FA in flask-user. 👍
As far as I can see,

  • onetimepass and
  • pyqrcode

should be added to install_requires in setup.py then.

@jasonehines
Copy link
Author

I'm not sure when I will have time to tackle the tests for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants