Create typingAttributesSetByApp to restore textView typingAttributes #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into issues where after a mention is detected, my textView's
typingAttributes
are not used.Looking at the code, it appears that after inserting a mention, the
typingAttributes
get recreated viastripCustomAttributesFromTypingAttributes
. This method takes the currenttypingAttributes
and removes all keys that are also inmentionUnselectedAttributes
. It then tries to recreatetypingAttributes
by usingfontSetByApp
andtextColorSetByApp
.My code never set these values, and instead was only using
typingAttributes
. After a mention was created, the font and foreground attributes would be removed bystripCustomAttributesFromTypingAttributes
, leaving my textView with notypingAttributes
.This is a simple change to also keep track of
typingAttributesSetByApp
. If intypingAttributesByStrippingMentionAttributes:
we see thattypingAttributesSetByApp
is non-nil, we return those. Otherwise we fall back onfontSetByApp
andtextColorSetByApp
.