metrics: Make hostname label on TLS metrics configurable #3561
+52
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <[email protected]>
zaharidichev
commented
Jan 24, 2025
| @@ -376,6 +384,12 @@ impl svc::Param<watch::Receiver<tls::Routes>> for TlsSidecar { | |||
| } | |||
| } | |||
|
|
|||
| impl svc::Param<AllowHostnameLabels> for TlsSidecar { | |||
There was a problem hiding this comment.
In my mind sticking that to the target allows for easier way to eventually rely on discovery information for configuring that options. Correct me if I am wrong here.
zaharidichev
commented
Jan 24, 2025
Comment on lines
+175
to
+177
| if let Some(hostname) = hostname { | ||
| ("hostname", hostname.to_string()).encode(enc.encode_label())?; | ||
| } |
There was a problem hiding this comment.
Now that I think about that, this might actually remove the label instead of blanking it. Will correct that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that illustrates a proposed approach for piping configuration for blanking the hostname label for outbound route metrics.