Remove aide_install phase and do it uncoditionally

Signed-off-by: Radovan Sroka <[email protected]>

README.md

@@ -55,14 +55,6 @@ Default: `files`
 
 Type: `string
 
-### aide_install
-
-With this variable the role ensures that the `aide` package is installed on the remote nodes
-
-Default: `false`
-
-Type: `bool`
-
 ### aide_init
 
 Initializes the AIDE database.

defaults/main.yml

@@ -9,9 +9,6 @@ aide_db_template: null
 # Examples of role input variables:
 aide_db_fetch_dir: files
 
-# Enable install phase
-aide_install: false
-
 # Enable initialization of the database phase
 aide_init: false
 

examples/custom-template.yml

@@ -7,7 +7,6 @@
       vars:
         aide_db_template: /tmp/aide-custom.conf.j2
         aide_db_fetch_dir: files
-        aide_install: true
         aide_init: true
         aide_fetch_db: true
         aide_check: true

examples/default.yml

@@ -6,7 +6,6 @@
     - name: Include role aide
       vars:
         aide_db_fetch_dir: files
-        aide_install: false
         aide_init: false
         aide_fetch_db: false
         aide_check: false

examples/deploy.yml

@@ -6,7 +6,6 @@
     - name: Include role aide
       vars:
         aide_db_fetch_dir: files
-        aide_install: true
         aide_init: true
         aide_fetch_db: false
         aide_check: false

examples/just_check.yml

@@ -6,7 +6,6 @@
     - name: Include role aide
       vars:
         aide_db_fetch_dir: files
-        aide_install: false
         aide_init: false
         aide_fetch_db: false
         aide_check: true

examples/just_update.yml

@@ -6,7 +6,6 @@
     - name: Include role aide
       vars:
         aide_db_fetch_dir: files
-        aide_install: false
         aide_init: false
         aide_fetch_db: false
         aide_check: false

tasks/main.yml

@@ -10,8 +10,6 @@
     state: present
     use: "{{ (__aide_is_ostree | d(false)) |
              ternary('ansible.posix.rhel_rpm_ostree', omit) }}"
-  when:
-    - aide_install | bool
 
 - name: Ensure required services are enabled and started
   ansible.builtin.service:

tests/tests_default.yml

@@ -16,5 +16,11 @@
         - name: Assert that the file exists
           ansible.builtin.assert:
             that:
-              - not file_check.stat.exists
-            fail_msg: "The file does exist."
+              - file_check.stat.exists
+            fail_msg: "The file does not exist."
+
+        - name: Check header for not present ansible_managed, fingerprint
+          include_tasks: tasks/check_not_present_header.yml
+          vars:
+            __file: /etc/aide.conf
+            __fingerprint: system_role:aide

tests/tests_deploy.yml

@@ -6,7 +6,6 @@
   roles:
     - role: linux-system-roles.aide
       vars:
-        aide_install: true
         aide_init: true
   tasks:
     - name: Check header for ansible_managed, fingerprint