test: use ipaserver role from collection if it exists #256

richm · 2025-02-03T23:29:18Z

No description provided.

richm · 2025-02-03T23:30:55Z

[citest]

richm · 2025-02-04T00:12:16Z

[citest]

richm · 2025-02-04T00:34:08Z

[citest]

richm · 2025-02-04T01:06:47Z

[citest]

richm · 2025-02-04T01:45:58Z

[citest]

rjeffman · 2025-02-04T11:39:57Z

@richm we plan to migrate all ansible_freeipa releases to a collection in late CY24Q2 in anything but CentOS 8 Stream (which is not supported anymore).

Do you think this change is needed?

On another point of view, a "galaxy role" would be nice to ensure collections are installed (or I'm missing something that already exists and I don't know).

richm · 2025-02-04T15:19:02Z

@richm we plan to migrate all ansible_freeipa releases to a collection in late CY24Q2 in anything but CentOS 8 Stream (which is not supported anymore).

Do you mean CY25?

There are a few problems with the basic ipa test:

the legacy role was removed from the latest packages in el9 and el10. So we have to use the FQCN of the role in that case.
the upstream CI was changed to use BEAKERLIB - so we have to now use some other way to distinguish if we can use the ansible-freeipa rpm package, or install the role directly from github
the ipaserver installation is failing:

2025-02-04T01:55:42Z DEBUG Name ipaserver.test.local resolved to {UnsafeIPAddress('10.31.9.54'), UnsafeIPAddress('fe80::1044:c6ff:fe29:5d99')}
2025-02-04T01:55:42Z WARNING Invalid IP address fe80::1044:c6ff:fe29:5d99 for ipaserver.test.local: cannot use link-local IP address fe80::1044:c6ff:fe29:5d99

Do you think this change is needed?

Something needs to be changed/fixed - not sure exactly what.

On another point of view, a "galaxy role" would be nice to ensure collections are installed (or I'm missing something that already exists and I don't know).

Not sure what you mean?

richm · 2025-02-04T15:39:53Z

[citest]

richm · 2025-02-04T17:25:45Z

[citest]

richm · 2025-02-04T17:46:39Z

[citest]

rjeffman · 2025-02-07T14:04:05Z

[citest]

rjeffman · 2025-02-07T14:43:48Z

[citest]

rjeffman · 2025-02-07T15:05:09Z

[citest]

rjeffman · 2025-02-07T15:09:26Z

[citest]

rjeffman · 2025-02-10T17:54:44Z

[citest]

rjeffman · 2025-02-10T18:18:04Z

[citest]

richm · 2025-02-11T00:07:31Z

@rjeffman once this merges - linux-system-roles/tft-tests#67 - you will be able to add this line https://github.com/linux-system-roles/certificate/blob/main/.github/workflows/tft.yml#L172

            ARTIFACTS_URL=${{ steps.set_vars.outputs.ARTIFACTS_URL }};\
            LSR_ANSIBLE_VERBOSITY=-vvv"

to get verbose output

richm · 2025-02-11T16:24:43Z

@rjeffman linux-system-roles/tft-tests#67 is merged - you can make the suggested change to tft.yml to get debugging output

rjeffman · 2025-02-11T17:40:31Z

[citest]

richm · 2025-02-11T18:18:08Z

[citest]

richm · 2025-02-11T21:40:36Z

[citest]

richm · 2025-02-11T22:01:20Z

[citest]

richm · 2025-02-11T22:15:57Z

[citest]

rjeffman · 2025-02-12T11:44:20Z

@richm thank you!

Now I have the needed info to look at it (even if it doesn't make sense to fail).

rjeffman · 2025-02-13T18:04:47Z

[citest]

rjeffman · 2025-02-13T18:22:30Z

[citest]

rjeffman · 2025-02-13T18:35:44Z

[citest]

rjeffman · 2025-02-13T19:12:53Z

[citest]

Signed-off-by: Rafael Guterres Jeffman <[email protected]>

rjeffman · 2025-02-13T19:46:06Z

[citest]

rjeffman · 2025-02-13T20:52:45Z

tests/tasks/setup_ipa.yml

+        echo "==========================="
+        echo "    ipaserver-install.log"
+        echo "==========================="
+        cat ipaserver-install.log
+        echo "==========================="
+        echo "    /var/log/messages"
+        echo "==========================="
+        cat /var/log/messages


@richm Is this the debug message that should be removed? I'm fine with simlpy removing it.

This is fine - I meant https://github.com/linux-system-roles/certificate/blob/main/.github/workflows/tft.yml#L173

May I suggest commenting out that line? It is great to have the indication, no the code, on how to reenable it.

Something like:

diff --git a/.github/workflows/tft.yml b/.github/workflows/tft.yml index ede80c4..68e5729 100644 --- a/.github/workflows/tft.yml +++ b/.github/workflows/tft.yml @@ -169,8 +169,8 @@ jobs: ARTIFACTS_DIR=${{ steps.set_vars.outputs.ARTIFACTS_DIR }};\ TEST_LOCAL_CHANGES=false;\ LINUXSYSTEMROLES_USER=${{ vars.LINUXSYSTEMROLES_USER }};\ - ARTIFACTS_URL=${{ steps.set_vars.outputs.ARTIFACTS_URL }};\ - LSR_ANSIBLE_VERBOSITY='-vvv'" + ARTIFACTS_URL=${{ steps.set_vars.outputs.ARTIFACTS_URL }};" + # To increase ansible verbosity add to variables: LSR_ANSIBLE_VERBOSITY='-vvv' # Note that LINUXSYSTEMROLES_SSH_KEY must be single-line, TF doesn't read multi-line variables fine. secrets: "LINUXSYSTEMROLES_DOMAIN=${{ secrets.LINUXSYSTEMROLES_DOMAIN }};\ LINUXSYSTEMROLES_SSH_KEY=${{ secrets.LINUXSYSTEMROLES_SSH_KEY }}"

codecov · 2025-02-13T21:26:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (ac27251) to head (98d7ac5).
Report is 33 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##             main   #256       +/-   ##
=========================================
- Coverage   32.95%      0   -32.96%     
=========================================
  Files           3      0        -3     
  Lines         613      0      -613     
  Branches      128      0      -128     
=========================================
- Hits          202      0      -202     
+ Misses        411      0      -411

Flag	Coverage Δ
sanity	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

richm requested review from rjeffman and spetrosi as code owners February 3, 2025 23:29

rjeffman force-pushed the test-use-ipa-collection branch from ace3ba5 to c1a6948 Compare February 7, 2025 14:03

rjeffman force-pushed the test-use-ipa-collection branch from c1a6948 to 508771b Compare February 7, 2025 14:19

rjeffman force-pushed the test-use-ipa-collection branch from 508771b to 8b65c74 Compare February 7, 2025 15:04

rjeffman force-pushed the test-use-ipa-collection branch from 2a85061 to a2f076c Compare February 10, 2025 18:17

test: use ipaserver role from collection if it exists

9049c7d

richm force-pushed the test-use-ipa-collection branch from 1623443 to e6ec81e Compare February 11, 2025 22:15

rjeffman force-pushed the test-use-ipa-collection branch from 3673814 to d90aa78 Compare February 13, 2025 18:33

test: Fix ipaserver deployment when using Testing Farm

98d7ac5

Signed-off-by: Rafael Guterres Jeffman <[email protected]>

rjeffman force-pushed the test-use-ipa-collection branch from 01bea01 to 98d7ac5 Compare February 13, 2025 19:43

rjeffman reviewed Feb 13, 2025

View reviewed changes

richm merged commit 117f474 into linux-system-roles:main Feb 13, 2025
23 checks passed

richm deleted the test-use-ipa-collection branch February 13, 2025 21:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: use ipaserver role from collection if it exists #256

test: use ipaserver role from collection if it exists #256

richm commented Feb 3, 2025

richm commented Feb 3, 2025

richm commented Feb 4, 2025

richm commented Feb 4, 2025

richm commented Feb 4, 2025

richm commented Feb 4, 2025

rjeffman commented Feb 4, 2025 •

edited

Loading

richm commented Feb 4, 2025

richm commented Feb 4, 2025

richm commented Feb 4, 2025

richm commented Feb 4, 2025

rjeffman commented Feb 7, 2025

rjeffman commented Feb 7, 2025

rjeffman commented Feb 7, 2025

rjeffman commented Feb 7, 2025

rjeffman commented Feb 10, 2025

rjeffman commented Feb 10, 2025

richm commented Feb 11, 2025

richm commented Feb 11, 2025

rjeffman commented Feb 11, 2025

richm commented Feb 11, 2025

richm commented Feb 11, 2025

richm commented Feb 11, 2025

richm commented Feb 11, 2025

rjeffman commented Feb 12, 2025

rjeffman commented Feb 13, 2025

rjeffman commented Feb 13, 2025

rjeffman commented Feb 13, 2025

rjeffman commented Feb 13, 2025

rjeffman commented Feb 13, 2025

rjeffman Feb 13, 2025

richm Feb 13, 2025

rjeffman Feb 13, 2025

rjeffman Feb 13, 2025 •

edited

Loading

codecov bot commented Feb 13, 2025

test: use ipaserver role from collection if it exists #256

test: use ipaserver role from collection if it exists #256

Conversation

richm commented Feb 3, 2025

richm commented Feb 3, 2025

richm commented Feb 4, 2025

richm commented Feb 4, 2025

richm commented Feb 4, 2025

richm commented Feb 4, 2025

rjeffman commented Feb 4, 2025 • edited Loading

richm commented Feb 4, 2025

richm commented Feb 4, 2025

richm commented Feb 4, 2025

richm commented Feb 4, 2025

rjeffman commented Feb 7, 2025

rjeffman commented Feb 7, 2025

rjeffman commented Feb 7, 2025

rjeffman commented Feb 7, 2025

rjeffman commented Feb 10, 2025

rjeffman commented Feb 10, 2025

richm commented Feb 11, 2025

richm commented Feb 11, 2025

rjeffman commented Feb 11, 2025

richm commented Feb 11, 2025

richm commented Feb 11, 2025

richm commented Feb 11, 2025

richm commented Feb 11, 2025

rjeffman commented Feb 12, 2025

rjeffman commented Feb 13, 2025

rjeffman commented Feb 13, 2025

rjeffman commented Feb 13, 2025

rjeffman commented Feb 13, 2025

rjeffman commented Feb 13, 2025

rjeffman Feb 13, 2025

Choose a reason for hiding this comment

richm Feb 13, 2025

Choose a reason for hiding this comment

rjeffman Feb 13, 2025

Choose a reason for hiding this comment

rjeffman Feb 13, 2025 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Feb 13, 2025

Codecov Report

rjeffman commented Feb 4, 2025 •

edited

Loading

rjeffman Feb 13, 2025 •

edited

Loading