Skip to content

Commit

Permalink
tst_net.sh: print test link type instead of $RHOST
Browse files Browse the repository at this point in the history
When message was added back in 18739ff, both rsh and ssh used $RHOST.
Later, when 5f8ca6c network namespaces support (TST_USE_NETNS=1) was
added it would have been better to print test link type (rsh/ssh/netns
at the time). Do it now.

NOTE: more debug info can be printed with TST_NET_RHOST_RUN_DEBUG=1
therefore no need to add more info about the connection here.

Link: https://lore.kernel.org/ltp/[email protected]/
Fixes: 5f8ca6c ("network: test_net.sh: allow to run network tests on a single machine")
Signed-off-by: Petr Vorel <[email protected]>
  • Loading branch information
pevik committed Jan 31, 2025
1 parent 4941395 commit 605e160
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion testcases/lib/tst_net.sh
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ tst_rhost_run()
if [ $ret -eq 1 ]; then
output=$(echo "$output" | sed 's/RTERR//')
[ "$safe" ] && \
tst_brk_ TBROK "'$cmd' failed on '$RHOST': '$output'"
tst_brk_ TBROK "'$cmd' failed on $use: '$output'"
fi

[ -z "$out" -a -n "$output" ] && echo "$output"
Expand Down

0 comments on commit 605e160

Please sign in to comment.