fix mmap/mremap address not aligned to MMAP_GRANULARITY #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 8, 2023 10:49
For some architectures like LoongArch, mmap(MAP_FIXED | MAP_SHARED) has to be aligned to SHMLBA. So use MMAP_GRANULARITY instead of page size when mmap, otherwise the test will fail. Suggested-by: Huacai Chen <[email protected]> Signed-off-by: Hongchen Zhang <[email protected]>
the target address of mremap should be aligned to MMAP_GRANULARITY, otherwise the test will fail. Signed-off-by: Hongchen Zhang <[email protected]>
the <start> parameter of remap_file_pages should be aligned to MMAP_GRANULARITY, otherwise the test will fail. Signed-off-by: Hongchen Zhang <[email protected]>
|
It looks like it works on x86_64, aarch64 and ppc64le |
@pevik Thanks for your review. |
|
@ZhangHongchen1 ok, so you use |
pevik
pushed a commit
that referenced
this pull request
Dec 11, 2023
For some architectures like LoongArch, mmap(MAP_FIXED | MAP_SHARED) has to be aligned to SHMLBA. So use MMAP_GRANULARITY instead of page size when mmap(), otherwise the test will fail. Link: #1113 Suggested-by: Huacai Chen <[email protected]> Reviewed-by: Petr Vorel <[email protected]> Signed-off-by: Hongchen Zhang <[email protected]>
pevik
pushed a commit
that referenced
this pull request
Dec 11, 2023
the target address of mremap() should be aligned to MMAP_GRANULARITY, otherwise the test will fail. Link: #1113 Reviewed-by: Petr Vorel <[email protected]> Signed-off-by: Hongchen Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we do mmap(MAP_SHARED),mmaped address should be aligned to MMAP_GRANULARITY,otherwise error will returned and the test will fail.
mremap and remap_file_pages should also follow this rule.