You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a difference between git reports of what is specified in Makefile to obtain git tag+commit: HEADS_GIT_VERSION := $(shell git describe --tags --dirty)
osresearch:
v0.2.0-1263-gf2e45c4
tlaurion:
v0.2.0-1263-gf2e45c43
Note the difference in length, being 7 or 8 characters above
Seems like the way to fix this would be to set the abbrev option to fixate length of commit length output: --abbrev[=<n>] use <n> digits to display object names
Github shows commit ids in an abbrev form of 7 characters. We should force the same inside of the builds for consistency and to avoid reproducibility issues on that: HEADS_GIT_VERSION := $(shell git describe --tags --abbrev=7 --dirty)
There is a difference between git reports of what is specified in Makefile to obtain git tag+commit:
HEADS_GIT_VERSION := $(shell git describe --tags --dirty)
osresearch:
v0.2.0-1263-gf2e45c4
tlaurion:
v0.2.0-1263-gf2e45c43
Note the difference in length, being 7 or 8 characters above
Seems like the way to fix this would be to set the abbrev option to fixate length of commit length output:
--abbrev[=<n>] use <n> digits to display object names
Github shows commit ids in an abbrev form of 7 characters. We should force the same inside of the builds for consistency and to avoid reproducibility issues on that:
HEADS_GIT_VERSION := $(shell git describe --tags --abbrev=7 --dirty)
Locally, this fixes the issue:
Originally posted by @tlaurion in #1225 (comment)
The text was updated successfully, but these errors were encountered: