fixate HEADS_GIT_VERSION to use a commit id of 7 characters #1228
Conversation
|
@JonathonHall-Purism : please review simple code change. Digging of the issue happened under #1008. The simplest way to test this would be to have a branch on your side corresponding to https://github.com/tlaurion/heads/tree/heads_git_version_fixated_to_abbrev7 We would expect the hashes to all be the same if nothing different installed on top of debian-11 (builds happening the same day, not resolving #936 issues) Outcome of this would be end users being able to replicate builds from CircleCI (until we have reproducible docker image to have stable and reproducible toolstack poked to have reproducible ROMs again). But meanwhile, a ROM build with the same tools on OS should produce the same ROMs. What was discovered under #1008 was that rebuilding for the same commit produced a different busybox binary. It is expected that what was installed on top of debian-11 varied (apt install) between two pipeline rebuilds without cache. More digging could be done to troubleshoot this, while having reproducible buildstack is another subject all together. Doing some digging under #1008 showed that my CircleCI instance, as opposed to osresearch's, was producing ROMs with HEADS_GIT_VERSION having different sizes of commit ID, resulting in ROMs being built the same day on two different CircleCI instances producing slightly different ROMs, simply because HEADS_GIT_VERSION was different. That difference was linked with master commit id being reported differently on the two CircleCI instances. This PR fixes that and only that to that HEADS_GIT_VERSION would have contained |
|
So @JonathonHall-Purism and Shows both :
Merging |
The commit hash length as produced by the genbuild_h.sh can differ depending on the environment (not really sure whether git version, config, or anything else is the reason here). By focing fixed length, we can improve build reproducibility on different machines, as this information is stored in the binary as the COREBOOT_ORIGIN_GIT_REVISION string. See below reference on heads issue describing similar problem: linuxboot/heads#1228 Signed-off-by: Maciej Pijanowski <[email protected]>
The commit hash length as produced by the genbuild_h.sh can differ depending on the environment (not really sure whether git version, config, or anything else is the reason here). By focing fixed length, we can improve build reproducibility on different machines, as this information is stored in the binary as the COREBOOT_ORIGIN_GIT_REVISION string. See below reference on heads issue describing similar problem: linuxboot/heads#1228 Signed-off-by: Maciej Pijanowski <[email protected]>
The commit hash length as produced by the genbuild_h.sh can differ depending on the environment (not really sure whether git version, config, or anything else is the reason here). By focing fixed length, we can improve build reproducibility on different machines, as this information is stored in the binary as the COREBOOT_ORIGIN_GIT_REVISION string. See below reference on heads issue describing similar problem: linuxboot/heads#1228 Signed-off-by: Maciej Pijanowski <[email protected]>
The commit hash length as produced by the genbuild_h.sh can differ depending on the environment (not really sure whether git version, config, or anything else is the reason here). By focing fixed length, we can improve build reproducibility on different machines, as this information is stored in the binary as the COREBOOT_ORIGIN_GIT_REVISION string. See below reference on heads issue describing similar problem: linuxboot/heads#1228 Signed-off-by: Maciej Pijanowski <[email protected]>
The commit hash length as produced by the genbuild_h.sh can differ depending on the environment (not really sure whether git version, config, or anything else is the reason here). By focing fixed length, we can improve build reproducibility on different machines, as this information is stored in the binary as the COREBOOT_ORIGIN_GIT_REVISION string. See below reference on heads issue describing similar problem: linuxboot/heads#1228 Signed-off-by: Maciej Pijanowski <[email protected]>
Force length of commit id to 7 characters to that variation of length is not a source of reproducibility errors.
Fixes #1227