Update hotp-verification (fixes #746)

[alex-nitrokey]

• use newer version of hotp-verification module to avoid patch
• testing new version on board

What do you think, shall I make two separate PRs instead?

(will fix #746)

[MrChromebox]

I'm a fan of separate PRs

[techge]

Tested and working.

Does it? It had some problems with it during initializing HOTP (hence still WIP).

[tlaurion]

@techge @AUX234 : This does: #756

[MrChromebox]

@tlaurion I'll need to retest to be sure, but IIRC this failed verification when I tested on a Librem13v4

[tlaurion]

#756 is just CBFS fix for x230-hotp-verification board which was reported not boot

[alex-nitrokey]

It boots and builds indeed, but for me it is not able to do the HOTP verification. Doesn't you had the problem?

Steps to reproduce:

• generate new HOTP secrets
• succeeds and key blinks green
• after that, every check let key blink red and invalid code message appears

[tlaurion]

Still not working.

[alex-nitrokey]

Still not working.

Just to make sure: you mean, you are experiencing the same, right?

[alex-nitrokey]

I found the issue as described here. It is very embarrasing, so let's not talk about it.

As soon as it is merged into master of hotp-verification I will update the version and hash here and thus the PR is ready to merge then.

[szszszsz]

@alex-nitrokey Just merged

[alex-nitrokey]

Builds and runs as intended, initialization and verification works fine.

[tlaurion]

#756 was merged meanwhile to fix #737

[tlaurion]

@alex-nitrokey @szszszsz : Non-reproducible.

[tlaurion]

Sorry closed by error and reopened.

[MrChromebox]

looks like we just need to update libremkey-hotp-verification_version to d4adfc58e53e61519adafc3dce2ddf729e7ebc86 (or later; master at 03a198c418a60c54ef3ec67ea8a9a2d29b675b9b currently) and adjust hash accordingly

[MrChromebox]

@stmc-droid see my comment above, this PR needs updating to fix the issue

[alex-nitrokey]

looks like we just need to update libremkey-hotp-verification_version to d4adfc58e53e61519adafc3dce2ddf729e7ebc86 (or later; master at 03a198c418a60c54ef3ec67ea8a9a2d29b675b9b currently) and adjust hash accordingly

I thought I updated this PR as well, but apparently I did it only in #761 hence the confusion, sorry.

[alex-nitrokey]

38ba257 is the corresponding commit which I just forgot to push last week.

[MrChromebox]

pushed #774 since this seems to have stalled, and wanted something working we can merge to get master back to functional ASAP

[techge]

Commit 38ba257 that is already in this PR should work and uses newer version of hotp-verification... Thus, I do not see the need for #744.

In the end I would suggest to merge #761 instead of the other two PRs anyway (they should not conflict anyway)

[MrChromebox]

if #761 is ready then correct no need, but the commit/PR message lists two items under 'things still needed' so my understanding was that it was not ready, and why I pushed a separate PR to fix the issue independently.

[techge]

but the commit/PR message lists two items under 'things still needed'

Mh, that is strange, aren't they ticked? I ticked them last week or so and they are ticked for me...

[MrChromebox]

they show as grey checkboxes for me, which contrasts with the green checkmarks used elsewhere on github so it certainly appears they are not completed

[szszszsz]

#748 (comment) is ticked both for me as well. Maybe you mean different one?

Edit: for the green check marks you need UTF-8 glyph AFAIK

[MrChromebox]

if that's ticked, then it's just horrible design

[techge]

if that's ticked, then it's just horrible design

Then it is :D

[tlaurion]

?!?

[MrChromebox]

guess it's a Chrome(ium)/Linux issue?

[techge]

Well, at least there are the marks 😂