Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix install fail caused by postinst execute fail #113

Merged
merged 1 commit into from
May 20, 2024

Conversation

wangrong1069
Copy link
Contributor

As title.

Log: fix package install fail
Task: https://pms.uniontech.com/task-view-348801.html

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • debian/postinst脚本中,useraddgroupadd命令的异常处理应该更加详细,以便在错误发生时能够更好地诊断问题。
  • 降低日志级别可能会导致重要的错误信息被忽略,应评估是否对性能有影响,并在必要时恢复错误日志。
  • 删除了initLogFile函数中的错误处理逻辑,如果logDir为空,则返回false,但这个逻辑被移除,可能会影响程序的健壮性。

是否建议立即修改:

Copy link

TAG Bot

TAG: 6.1.9
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: re2zero, wangrong1069

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangrong1069
Copy link
Contributor Author

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 20, 2024

This pr cannot be merged! (status: unstable)

@wangrong1069
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 20, 2024

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 61beb19 into linuxdeepin:master May 20, 2024
18 of 19 checks passed
@wangrong1069 wangrong1069 deleted the delay_index branch December 25, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants