fix: fix crash caused by multi-threaded access #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the thread in `EventAdaptor` and use the main thread timer to dispatch events directly. `EventSource_GENL` asynchronously calls `MountCacher::updateMountPoints` to avoid multi-threaded access. Use `Q_GLOBAL_STATIC` to create a singleton, and do not allow static acquisition. Log: fix deepin-anything-server crash Bug: https://pms.uniontech.com/bug-view-264761.html
deepin pr auto review关键摘要:
是否建议立即修改: 这些修改可能会导致线程安全问题、未处理的初始化状态和内存泄漏。为了保持代码的稳定性和完整性，建议立即进行修改。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: re2zero, wangrong1069 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/merge |
|
This pr cannot be merged! (status: unstable) |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the thread in
EventAdaptorand use the main thread timer to dispatch events directly.EventSource_GENLasynchronously callsMountCacher::updateMountPointsto avoid multi-threaded access. UseQ_GLOBAL_STATICto create a singleton, and do not allow static acquisition.Log: fix deepin-anything-server crash
Bug: https://pms.uniontech.com/bug-view-264761.html