Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [python] Python interpreter #1020

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

Kakueeen
Copy link
Contributor

Some python interpreters are not visible in the Project Properties Dialog

Log: fix issue

Some python interpreters are not visible in the `Project Properties Dialog`

Log: fix issue
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • getSystemPython函数中,ToolChainData::Params类型的返回值被直接返回,但没有检查tcData.readToolChainData是否成功。
  • getSystemPython函数的命名不够明确,建议改为getAvailablePythonVersions或类似名称。
  • DetailPropertyWidget::initData函数中,OptionManager::getInstance()->getValue的参数从{"Interpreter"}更改为"Interpreter",这可能会影响函数的行为,需要确认是否正确。
  • DetailPropertyWidget::initData函数中,globalToolPath变量未在代码片段中定义,可能会导致编译错误或运行时错误。
  • DetailPropertyWidget::initData函数中,d->pyVersionComboBox->setItemDataQt::UserRole + 1可能需要定义一个常量来提高代码的可读性。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kakueeen, LiHua000
Once this PR has been reviewed and has the lgtm label, please assign deepin-mozart for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-mozart deepin-mozart merged commit d6bffe8 into linuxdeepin:master Dec 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants