-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [aiManager] add interface #1031
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,10 +5,11 @@ | |
#include "aimanager.h" | ||
#include "services/ai/aiservice.h" | ||
#include "openai/openaicompatiblellm.h" | ||
#include "services/option/optionmanager.h" | ||
#include "option/detailwidget.h" | ||
#include "common/util/eventdefinitions.h" | ||
|
||
#include <QMap> | ||
|
||
using namespace dpfservice; | ||
|
||
|
@@ -83,10 +84,22 @@ | |
|
||
void AiManager::readLLMFromOption() | ||
{ | ||
auto currentModels = d->models; | ||
bool changed = false; | ||
d->models.clear(); | ||
|
||
QMap<QString, QVariant> map = OptionManager::getInstance()->getValue(kCATEGORY_CUSTOMMODELS, kCATEGORY_OPTIONKEY).toMap(); | ||
auto LLMs = map.value(kCATEGORY_CUSTOMMODELS); | ||
if (LLMs.toList().size() != currentModels.size()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 不应该通过个数来判断,模型自身参数的变化也应该有通知 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 通过个数判断是为了快速判断模型有没有被删除,不然需要额外用一个循环来判断当前模型是否被删除。 现在还没有支持模型的参数修改,只有新增和删除。 |
||
changed = true; | ||
|
||
for (auto llmInfo : LLMs.toList()) { | ||
appendModel(LLMInfo::fromVariantMap(llmInfo.toMap())); | ||
LLMInfo info = LLMInfo::fromVariantMap(llmInfo.toMap()); | ||
if (!currentModels.contains(info)) | ||
changed = true; | ||
appendModel(info); | ||
} | ||
|
||
if (changed) | ||
ai.LLMChanged(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个事件只表示模型数量发生了改变,事件名应该为modelCountChanged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不是 是模型发生了变化就会发送,不管是模型被删除还是新增。 判断的那里设置Changed,两个判断 一个是模型被删除 一个是有新增
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
包括先删除再新增,数量不变,但是模型变化了,也会发送事件