Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [session] Add auto-close dialog after session switch #1033

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

Kakueeen
Copy link
Contributor

Enhance session management UX by automatically closing the session dialog
when user switches to a different session. This improvement streamlines
the workflow by:

  • Adding new sessionSwitched signal in SessionListView
  • Connecting dialog close action to session switch event
  • Maintaining clean state transitions during session changes

Log: Add auto-close behavior to session dialog after session switch
Bug: https://pms.uniontech.com/bug-view-298077.html

Enhance session management UX by automatically closing the session dialog
when user switches to a different session. This improvement streamlines
the workflow by:

- Adding new sessionSwitched signal in SessionListView
- Connecting dialog close action to session switch event
- Maintaining clean state transitions during session changes

Log: Add auto-close behavior to session dialog after session switch
Bug: https://pms.uniontech.com/bug-view-298077.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • SessionDialog::initConnect函数中新增的connect语句可能会导致逻辑错误,因为sessionSwitched信号在SessionListView::switchToCurrentSession函数中被发射,但这个函数可能被频繁调用,导致SessionDialog::close函数被频繁调用。
  • SessionListView::sessionSwitched信号的发射没有对应的槽函数来处理,这可能会导致未处理的信号。

是否建议立即修改:

@deepin-mozart deepin-mozart merged commit 3d7d662 into linuxdeepin:master Dec 31, 2024
9 of 10 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart, Kakueeen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants