Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UI] Change the background color to active color #1034

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

Kakueeen
Copy link
Contributor

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • plugindetailsview.cpp文件中,#include指令的缩进不一致,建议统一缩进风格。
  • AutoZoomWebEngineView类的定义和成员函数的声明之间缺少空行,建议添加空行以提高代码可读性。
  • resizeEvent函数中的QWebEngineView::resizeEvent(event);调用后缺少分号,应添加分号。
  • eventFilter函数中的QPainter对象painter未在函数末尾释放,建议使用QPainter的RAII特性。
  • DetailsView类的eventFilter函数中,QPaintersetBrushsetPen方法调用后缺少分号。
  • DetailsView类的initMetaInfoLayout函数中,categoryFrame的创建和设置被简化为直接创建category对象,建议检查是否所有相关功能都已迁移到category对象。
  • DetailsView类的initMetaInfoLayout函数中,category对象的installEventFilter调用后缺少分号。
  • DetailsView类的initMetaInfoLayout函数中,hbox->addWidget(categoryFrame);被替换为hbox->addWidget(category);,需要确认这一改动是否符合设计要求。

是否建议立即修改:

@deepin-mozart deepin-mozart merged commit 8fd2ff2 into linuxdeepin:master Dec 31, 2024
9 of 10 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart, Kakueeen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants