Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkcore #49

Merged
merged 1 commit into from
May 24, 2024
Merged

sync: from linuxdeepin/dtkcore #49

merged 1 commit into from
May 24, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#413

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-413-nosync branch 8 times, most recently from ee3bad0 to db94877 Compare May 14, 2024 09:19
@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 15, 2024

TAG Bot

New tag: 6.0.16
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #52

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#413
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DSysInfoPrivate::ensureDeepinInfo()函数中,static_cast<int>(deepinType)应该使用std::int来确保类型安全。
  • QJsonDocument::fromJson的错误处理不够充分,仅仅是打印了错误信息,应该考虑抛出异常或者提供更详细的错误报告。
  • QString::replace使用{}替换;,可能会导致日志格式不一致,建议统一日志格式。
  • Q_LOGGING_CATEGORY宏的使用应该检查Q_ENABLE_LOGGING宏是否已经定义,以避免未定义宏时产生错误。
  • m_ignoreEnvPattern成员变量的命名不够明确,建议使用更具描述性的命名。
  • initLoggingRules函数中,qEnvironmentVariableIsSet环境变量检查应该在initLoggingRules之前完成,以避免重复检查。
  • createDConfig函数中,delete config;应该在return nullptr;之后执行,以避免释放未使用的内存。
  • updateLoggingRules函数中,QLoggingCategory::setFilterRules的调用应该在if (var.isValid())条件判断之后,否则可能会尝试设置无效的日志规则。

是否建议立即修改:

@kegechen kegechen merged commit 6d90c06 into master May 24, 2024
10 of 11 checks passed
@kegechen kegechen deleted the sync-pr-413-nosync branch May 24, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants