-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove LoggingRules interface #422
Conversation
Whale107
commented
May 29, 2024
•
edited
Loading
edited
- 废弃相关接口, 默认启用(可以用 DTK_DISABLED_LOGGING_RULES 禁用)
- 如果用户通过 DTK_LOGGING_FALLBACK_APPID 指定 了fallbackAppId, 则优先使用 fallbackAppId, 否则使用 dsgAppId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
测试一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这是从 master 分支 cherry-pick 过来的代码?如果需要新接口,使用 DTK 的新版本,不应该往 release/5.6 上加接口。
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Whale107 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Whale107 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
已更新 |
- 废弃相关接口, 默认启用(可以用 DTK_DISABLED_LOGGING_RULES 禁用) - 如果用户通过 DTK_LOGGING_FALLBACK_APPID 指定 了fallbackAppId, 则优先使用 fallbackAppId, 否则使用 dsgAppId
deepin pr auto review关键摘要:
是否建议立即修改:
|
会从master重新拉release分支,此pr关闭 |