Add possibility to specify address range when binding with SMSC #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
My two cents, the Functional Option should also be added to Transmitter bind, address_range (addr_ton, addr_npi) are allowed in the bind_transmitter body. |
|
@laduchesneau : Even if it's technically possible to provide address_range in a transmitter bind, it is not expected according to the specification :
|
linxGnu
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using the lib to connect to SMSC but there was no way to setup the address range parameter within the connector.
We saw that the bindRequest struct was responsible for it and we took the freedom to improve the way we instantiate the connector.
With this pull request you can see that on the Receiver and Transceiver, we can now modify the connector without breaking the public interface of the lib. Which can now be used to add the addressRange option.