Single indent the long "flat" form of function definitions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
commented
Oct 1, 2024
| @@ -14,7 +14,7 @@ codegrip provides [RStudio addins](http://rstudio.github.io/rstudioaddins/) and | |||
|
|
|||
| <img src="man/figures/README/reshape-call.svg"/> | |||
|
|
|||
| Note that for function definitions, `addin_reshape` cycles through two different long shapes. The traditional L form uses more horizontal space whereas the flat form uses less horizontal space and the arguments are always aligned at double indent: | |||
| Note that for function definitions, `addin_reshape` cycles through two different long shapes. The traditional L form uses more horizontal space whereas the flat form uses less horizontal space and the arguments are always aligned at single indent: | |||
|
|
|||
| <img src="man/figures/README/reshape-def.svg"/> | |||
There was a problem hiding this comment.
@lionel- we will need you to regenerate this svg video thing
DavisVaughan
commented
Oct 1, 2024
|
|
||
| * The long "flat" form for function definitions now aligns arguments using a | ||
| single indent rather than a double indent, which follows the | ||
| [tidyverse style guide](https://style.tidyverse.org/functions.html#long-lines-1) |
There was a problem hiding this comment.
Well, itll reflect this after tidyverse/style#223 is merged
lionel-
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Aligns with tidyverse/style#223
Screen.Recording.2024-10-01.at.3.18.05.PM.mov
Also added a NEWS file
Note that there is currently an existing bug in codegrip when there is a function argument that is a call spanning multiple lines. Even if it starts with the right indentation we can't roundtrip it. It is unrelated to this PR (I think) but I wanted to call it out since you will see it in the snapshots.
Before this PR:
Screen.Recording.2024-10-01.at.3.14.34.PM.mov
After this PR:
Screen.Recording.2024-10-01.at.3.13.29.PM.mov