Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment script minor tweaks #723

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Deployment script minor tweaks #723

merged 5 commits into from
Jan 21, 2025

Conversation

bingen
Copy link
Collaborator

@bingen bingen commented Jan 20, 2025

No description provided.

@bingen bingen self-assigned this Jan 20, 2025
@bingen bingen force-pushed the deployment_tweaks branch from 43281b9 to 4827cda Compare January 20, 2025 15:54
@bingen bingen force-pushed the deployment_tweaks branch from 4827cda to fab9040 Compare January 20, 2025 16:29
Also, avoid adding a new dependency (@ethereumjs/util) for something
we can already do with an existing dependency (viem).
Copy link
Collaborator

@danielattilasimon danielattilasimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tweaks! Especially hiding private keys from the output.

@bingen bingen merged commit 54d5cf8 into main Jan 21, 2025
9 checks passed
@bingen bingen deleted the deployment_tweaks branch January 21, 2025 12:09
@bingen
Copy link
Collaborator Author

bingen commented Jan 21, 2025

Thanks for your additions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants