Skip to content

v3.5.1 Hotfix 🔥🛠
Compare
Choose a tag to compare
@kcw-grunt kcw-grunt released this 12 Jun 07:58
· 22 commits to main since this release
v3.5.1-hotfix
5da45ce
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Hotfix

Critical bug found in v3.5.0 where the tabs in Non-US Users couldn't navigate Receive and Buy tabs

Fix

The NonUS TabBarItems were using item.tag and they were set incorrectly and this was set properly

Post Mortem

The design patterns leveraging the tag are inherently poor and this offers an example why. The migration to a SwiftUI paradigm may be an opportunity to strengthen the architecture removing the usage of tags.

Meanwhile, adding more tests to the current code base will always help. So, tests for the US and NonUS TabBarViewControllers were included. In addition, another currency test was refactored.

Assets 2
Loading