Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated litestar.contrib.attrs import #3948

Conversation

mohammedbabelly20
Copy link
Contributor

Description

litestar.contrib.attrs was moved to litestar.plugins.attrswas in #3862 but still being used in code and gives warnings

Closes

@mohammedbabelly20 mohammedbabelly20 requested review from a team as code owners January 13, 2025 05:54
@mohammedbabelly20 mohammedbabelly20 changed the title fix remove deprecated litestar.contrib.attrs import fix: remove deprecated litestar.contrib.attrs import Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (2db1f4d) to head (b253402).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3948   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         347      347           
  Lines       15743    15743           
  Branches     1740     1740           
=======================================
  Hits        15483    15483           
  Misses        124      124           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3948

@Alc-Alc
Copy link
Contributor

Alc-Alc commented Jan 13, 2025

Thanks for the PR, the same fix was suggested here a bit earlier, closing this in favor of that. #3947

@Alc-Alc Alc-Alc closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants