feat(debugger): passing debugger to app

[oek1ng]

Description

Passing debugger_module variable to app

• Added type for pdb-like module, which supports post_mortem method
• Added debugger test app
• Added doc

Closes

#3949

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (f2da7ed) to head (0dfd519).
Report is 16 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3967   +/-   ##
=======================================
  Coverage   98.34%   98.35%           
=======================================
  Files         347      348    +1     
  Lines       15743    15793   +50     
  Branches     1740     1745    +5     
=======================================
+ Hits        15483    15533   +50     
  Misses        124      124           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[oek1ng]

Not sure about that

[euri10]

not sure either but the tying pros here will kmow _)

[provinzkraut]

Why not just have the post_mortem as

@staticmethod
def post_mortem(
    traceback: TracebackType | None = None,
    *args: Any,
    **kwargs: Any,
) -> Any: ...

instead of an exact match for every single one?

[oek1ng]

Why not just have the post_mortem as

@staticmethod
def post_mortem(
    traceback: TracebackType | None = None,
    *args: Any,
    **kwargs: Any,
) -> Any: ...

instead of an exact match for every single one?

thought about it, these methods have different signatures, and I don't like "Any" much, maybe your solution is better

[oek1ng]

@provinzkraut your solution works fine, should i change it?

[provinzkraut]

Yes please

[oek1ng]

Yes please

got u

[oek1ng]

@sobolevn I'd like if you review me

[euri10]

some minor comments on my side, though I wasnt able to be sent into pdb on an exception, is it working or im doing something stupid ?

using this app:

import pdb

import uvicorn

from litestar import Litestar, get


@get("/")
async def exc() -> str:
    1 / 0
    return "Hello World"


app = Litestar(route_handlers=[exc], debugger_module=pdb, debug=True)


if __name__ == "__main__":
    uvicorn.run(
        "qq:app",
        reload=True,
    )

[euri10]

ok answering to myself why I couldnt pop in pdb, it is because requires pdb_on_exception=True so I think the docs should show a "working" example.

[oek1ng]

ok answering to myself why I couldnt pop in pdb, it is because requires pdb_on_exception=True so I think the docs should show a "working" example.

Yeah, you're right, ty

[euri10]

LGTM thanks !

[github-actions]

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3967