-
-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: gunicorn with uvicorn workers #3973
docs: gunicorn with uvicorn workers #3973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we should, as it's not really something I'd recommend anyway, and neither does uvicorn, since they've improved their own proc management.
@litestar-org/members @litestar-org/maintainers if you feel differently, please weigh in
I wouldnt recommend it either, but then we need to update the issue linked so that efforts like this aren't made for nothing. |
Good point. Done. |
I wouldn't recommend it either. Considering that users might search for the keyword Since some developers might not be aware that the latest Uvicorn versions no longer need to deploy with Gunicorn for multi-workers, providing it could be helpful. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3973 +/- ##
==========================================
- Coverage 98.34% 98.34% -0.01%
==========================================
Files 347 347
Lines 15756 15756
Branches 1741 1741
==========================================
- Hits 15496 15495 -1
- Misses 124 126 +2
+ Partials 136 135 -1 ☔ View full report in Codecov by Sentry. |
cfe4af2
to
9488851
Compare
I think it should be just that notice |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3973 |
Description
NOTE
The Gunicorn+Uvicorn pattern is considered legacy for ASGI deployments since Uvicorn 0.30.0+ includes native worker management.
References:
Closes
Part of #2609