Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): wfrun blank page #1316

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

bryson-g
Copy link
Contributor

@bryson-g bryson-g commented Feb 19, 2025

Description

  • Refactored the id pulled from the url, which is passed to the wfRun page component, to be formatted via WfRunId object instead of just the string
  • Refactored SWR implementation to avoid running the getWfRun request if there is no valid ID present

Video

Screen.Recording.2025-02-19.at.8.38.40.AM.mov

@bryson-g bryson-g added the bug An issue with correctness, stability, performance, or API conformance. label Feb 19, 2025
@bryson-g bryson-g self-assigned this Feb 19, 2025
@bryson-g bryson-g requested a review from hazimoarafa February 19, 2025 16:40
@bryson-g bryson-g merged commit ee9ddfb into master Feb 19, 2025
24 checks passed
@bryson-g bryson-g deleted the fix-inherited-variables-and-wfrunids branch February 19, 2025 16:46
export function useWfRun({ wfRunId, tenantId }: Props) {
const [dataCache, setDataCache] = useState<WfRunResponse | null>(null)

const { error, isLoading } = useSWR(`wfRun/${tenantId}/${wfRunId.id}/${wfRunId.parentWfRunId?.id}`, async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't matter but don you want to flip parentwf and normal wf in this string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with correctness, stability, performance, or API conformance.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants