Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved grammar and fixed spelling and punctuation in the documentation. #374

Merged

Conversation

hassansuhaib
Copy link
Contributor

This is a

  • Bug fix
  • Feature
  • Doc improvement

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

  • I have used Preevy for a while and am familiar with the function it provides.

@hassansuhaib hassansuhaib changed the title Doc improvement/grammar punctuation spelling Improved grammar and fixed spelling and punctuation. Dec 19, 2023
@hassansuhaib hassansuhaib changed the title Improved grammar and fixed spelling and punctuation. Improved grammar and fixed spelling and punctuation in the documentation. Dec 19, 2023
Copy link
Collaborator

@royra royra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create this PR! Can you share how you went over the docs? Did you use a tool?

See comments re generated docs and some nits.

site/docs/ci/index.mdx Outdated Show resolved Hide resolved
* [`preevy init`](init.md) - Initialize or import a new profile
* [`preevy login`](login.md) - Login to the Livecycle SaaS
* [`preevy logs`](logs.md) - Show logs for an existing environment
* [`preevy ls`](ls.md) - List preview environments
* [`preevy profile`](profile.md) - View and update profile configuration
* [`preevy purge`](purge.md) - Delete all cloud provider machines, and potentially other resources
* [`preevy purge`](purge.md) - Delete all cloud provider machines and potentially other resources
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI reference is auto-generated from the code - any changes will be reverted. You can make the change at the appropriate file in the commands dir

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now made the change in the appropriate file. I am leaving this here so that these docs remain updated.

@@ -5,6 +5,6 @@ parent: /dashboard

## **Share code changes. Collect feedback.**

Livecycle makes it easy to not only create previews of your latest changes, but also to share them and collect feedback in context.
Livecycle makes it easy to not only create previews of your latest changes but also to share them and collect feedback in context.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure removing the comma makes a better or more correct sentence

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct according to Grammarly.

@@ -75,7 +75,7 @@ BASE_URL=http://localhost:8030 docker compose -f docker-compose.yml -f docker-co

### 3. Expose the service's SSH endpoint

Now we want to expose the tunnel service to the internet, so the machines running in the cloud could access it. In this example we'll be using [ngrok](https://ngrok.com/) to achieve that:
Now we want to expose the tunnel service to the internet, so the machines running in the cloud can access it. In this example, we'll be using [ngrok](https://ngrok.com/) to achieve that:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure removing the comma makes a better or more correct sentence

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comma is removed; instead, one is added.

@@ -7,7 +7,7 @@ title: Deploy to Google Cloud Platform

Preevy can provision virtual machines on GCP using the `gce` driver.
Google compute engine provisioning time for a VM is usually less than a minute, the default machine size in use is e2-small (2GB, 2vCpu) which costs around $12 per month.
Google compute also offer $300 free credit for new users which is suited for trying out preevy.
Google Compute also offers a $300 free credit for new users which is suited for trying out preevy.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure "a" is correct here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct.

site/docs/intro/index.md Outdated Show resolved Hide resolved
@@ -51,7 +51,7 @@ Example AWS S3 URL:
s3://preevy-config/profile1?region=us-east-1
```

Refers to a profile stored on a S3 bucket named `preevy-config` in the region `us-east-1` under the base path `profile1`.
Refers to a profile stored on an S3 bucket named `preevy-config` in the region `us-east-1` under the base path `profile1`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure "an" is correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct.

site/docs/intro/under-the-hood.md Outdated Show resolved Hide resolved
@hassansuhaib
Copy link
Contributor Author

hassansuhaib commented Dec 20, 2023

Thanks for taking the time to create this PR! Can you share how you went over the docs? Did you use a tool?

See comments re generated docs and some nits.

I used Grammarly.

@hassansuhaib hassansuhaib force-pushed the doc-improvement/grammar_punctuation_spelling branch from 1f18fda to 12513f3 Compare December 20, 2023 05:31
site/docs/welcome.mdx Outdated Show resolved Hide resolved
@royra royra merged commit ee4e6a0 into livecycle:main Dec 20, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants