Improve Ingress A/V sync #154
Merged
+266
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostbyte73
approved these changes
Oct 16, 2023
biglittlebigben
added a commit
that referenced
this pull request
Oct 17, 2023
## Changelog ### Added - Implement high motion presets (#153) ### Fixed - Add queues between pipeline steps (#146) - Small quality/resource usage/latency tuning for x264 and vp8 encoding parameters (#147) - Adopt COMPLETE state for URL ingress. Use udp port multiplexing by default for WHIP (#148) - Do not attempt to unpublish a track from a closed room (#150) - Use souphttpsrc as it provides better error messages (#151) - Improve Ingress A/V sync (#154)
Merged
biglittlebigben
added a commit
that referenced
this pull request
Oct 18, 2023
Verson 1.2.0 ## Changelog ### Added - Implement high motion presets (#153) ### Fixed - Add queues between pipeline steps (#146) - Small quality/resource usage/latency tuning for x264 and vp8 encoding parameters (#147) - Adopt COMPLETE state for URL ingress. Use udp port multiplexing by default for WHIP (#148) - Do not attempt to unpublish a track from a closed room (#150) - Use souphttpsrc as it provides better error messages (#151) - Improve Ingress A/V sync (#154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves ingress A/V sync by ensuring that buffers are sent to the local participant object at a time that matches their timestamp.
In order to not introduce large delays, also drop late media data at the beginning of the session.