Build fixes #559
Merged
Build fixes #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Dmitry described in [1] changelog the current way of detecting -s option is broken for new make. Changing the tools/build -s option detection the same way as it was fixed for root Makefile in [1]. [1] 4bf7358 ("kbuild: Port silent mode detection to future gnu make.") Cc: Dmitry Goncharov <[email protected]> Signed-off-by: Jiri Olsa <[email protected]> Tested-by: Arnaldo Carvalho de Melo <[email protected]> Acked-by: Namhyung Kim <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: KP Singh <[email protected]> Cc: Martin KaFai Lau <[email protected]> Cc: Song Liu <[email protected]> Cc: Yonghong Song <[email protected]> Cc: John Fastabend <[email protected]> Cc: Hao Luo <[email protected]> Cc: Ian Rogers <[email protected]> Cc: Stanislav Fomichev <[email protected]> Cc: Daniel Borkmann <[email protected]> Cc: Quentin Monnet <[email protected]> Cc: Arnaldo Carvalho de Melo <[email protected]> Cc: Andrii Nakryiko <[email protected]> Cc: Alexei Starovoitov <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: [email protected] Cc: [email protected] Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Namhyung Kim <[email protected]>
|
@ddiss could you please check if this fixes the parallel build issue on you side? Not a great solution but it is fairly isolated and simple. |
Thanks for the patch! will give it a spin on the Build Service today |
tavip
force-pushed
the
lkl-build-fixes
branch
from
a639c25 to
b4e2599
Compare
|
The change looks good, but https://www.gnu.org/software/make/manual/html_node/Parallel-Disable.html doesn't really explain how |
tools/build does not support parallel builds when objects are shared between build targets. Keep the test that uses the most common object first and insert a build barrier to avoid rebuilding common objects. Signed-off-by: Octavian Purdila <[email protected]>
Separate the tests targets in a different set so that we don't install them with make install. Signed-off-by: Octavian Purdila <[email protected]>
tavip
force-pushed
the
lkl-build-fixes
branch
from
b4e2599 to
e758fd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports a patch from upstream to fix build output for test targets and add a workaround to fix parallel builds for tests. Fixes #558.
Jiri Olsa (1):
tools/build: Fix -s detection code in tools/build/Makefile.build
Octavian Purdila (2):
lkl: add tests build barrier
lkl: don't install tests
tools/build/Makefile.build | 10 +++++++++-
tools/lkl/Makefile | 15 +++++++++++----
tools/lkl/Targets | 17 +++++++++++------
3 files changed, 31 insertions(+), 11 deletions(-)