review comments: use early exit code convention

llvm · Jan 16, 2025 · a76b907 · a76b907
1 parent 8e88fa7
commit a76b907
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/clang/lib/Parse/ParseHLSLRootSignature.cpp b/clang/lib/Parse/ParseHLSLRootSignature.cpp
@@ -28,19 +28,18 @@ bool RootSignatureLexer::LexNumber(RootSignatureToken &Result) {
   if (Literal.hadError)
     return true; // Error has already been reported so just return
 
+  if (!Literal.isIntegerLiteral())
+    return true; // TODO: report unsupported number literal specification
+
   // Retrieve the number value to store into the token
-  if (Literal.isIntegerLiteral()) {
-    Result.Kind = TokenKind::int_literal;
+  Result.Kind = TokenKind::int_literal;
 
-    APSInt X = APSInt(32, Result.Signed);
-    if (Literal.GetIntegerValue(X))
-      return true; // TODO: Report overflow error
+  APSInt X = APSInt(32, Result.Signed);
+  if (Literal.GetIntegerValue(X))
+    return true; // TODO: Report overflow error
 
-    X = Negative ? -X : X;
-    Result.IntLiteral = (uint32_t)X.getZExtValue();
-  } else {
-    return true; // TODO: report unsupported number literal specification
-  }
+  X = Negative ? -X : X;
+  Result.IntLiteral = (uint32_t)X.getZExtValue();
 
   AdvanceBuffer(NumSpelling.size());
   return false;