-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections #122215
Merged
mingmingl-llvm
merged 23 commits into
main
from
users/mingmingl-llvm/spr/sdptargetlowering
Jan 29, 2025
+173
−50
Merged
[AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections #122215
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
5d207e9
[SDP]Introduce StaticDataSplitter pass and implemenet jump table spli…
mingmingl-llvm 34b6b9b
Flag-gate the new pass and resolve review feedback
mingmingl-llvm dd74827
rely to upstream
mingmingl-llvm 8d3a985
Emit jump table with section suffix
mingmingl-llvm 1bacc51
Apply suggestions from code review
mingmingl-llvm 8a85d1a
resolve review feedback
mingmingl-llvm e54dacb
Discover jump table by calling MachineOperand::isJTI()
mingmingl-llvm 27ef86d
Introduce a TargetMachine option , and the command line flag option t…
mingmingl-llvm e816def
Emit jump tables into .hot and .unlikely sections respectively
mingmingl-llvm 28defd8
merge base patch
mingmingl-llvm 7f3e473
Add -mtriple=x86_64-unknown-linux-gnu for test
mingmingl-llvm 1bef9b1
run clang format
mingmingl-llvm 59a958a
Apply suggestions from code review
mingmingl-llvm 2d06092
fix windows build bot failure
mingmingl-llvm 9134ffa
resolve comments
mingmingl-llvm ea2d838
merge with main branch
mingmingl-llvm 027ae56
resolve review feedback
mingmingl-llvm fd0034a
[NFCI]Refactor AsmPrinter around jump table emission
mingmingl-llvm a79a789
Merge branch 'main' into users/mingmingl-llvm/spr/nfcprecommit
mingmingl-llvm d569eff
display diff after refactor
mingmingl-llvm be96277
git merge main
mingmingl-llvm b919de9
resolve comments
mingmingl-llvm 6bb4b32
Resolve comments. Also append a dot when -fno-unique-section-names is…
mingmingl-llvm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will happen to the case where
JTE->Hotness == MachineFunctionDataHotness::Unknown
? I think the behaviour we want is to fall back to the section prefix. Can you add a test if you agree?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense. Done.
The updated PR has
@bar
for test coverage.