-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Refresh add_ops.md #3939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjacobgordon
force-pushed
the
docs-refreshes-add-ops-md
branch
from
January 3, 2025 21:15
39a20d5
to
e3eb6c6
Compare
Cleaned up this doc while going through Turbine Camp!
It'll probably be quicker to review each one individually! @marbre I think this'll be an easy one! Could you review it? |
bjacobgordon
force-pushed
the
docs-refreshes-add-ops-md
branch
from
January 3, 2025 21:21
e3eb6c6
to
2135d7e
Compare
marbre
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going over this. Some first comments.
bjacobgordon
force-pushed
the
docs-refreshes-add-ops-md
branch
3 times, most recently
from
January 6, 2025 22:23
50f1905
to
2bff98d
Compare
- applied by markdown linter
- applied by markdown linter
- applied by markdown linter
- applied by markdown linter
- applied by markdown linter
- applied by markdown linter
- addresses issues mentioned by markdown linter - avoids less-common 0-based lists since that would require deviation from the default linter config
…locks - addresses issues mentioned by markdown linter
- Each line of detail either: - already existed internally in [Confluence](https://confluence.amd.com/display/SHARK/Turbine+Camp) OR - was severely out of date! - Was beyond the concerns of Torch-MLIR
- was directed to a specific style guide rule rather than the start of the style guide in general
bjacobgordon
force-pushed
the
docs-refreshes-add-ops-md
branch
from
January 7, 2025 15:26
2bff98d
to
87da8ed
Compare
marbre
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OR