Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web): Radio button with multiple lines label #DS-1664 #1865

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Jan 23, 2025

Description

Additional context

Issue reference

@curdaj curdaj added the run-visual-tests Runs visual regression testing on this PR label Jan 23, 2025
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 5ae33ca
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67938bc48b6bbd00085d6b1b

@github-actions github-actions bot added the bug Something isn't working label Jan 23, 2025
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 5ae33ca
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67938bc49952e00008487b98
😎 Deploy Preview https://deploy-preview-1865--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@curdaj curdaj marked this pull request as ready for review January 23, 2025 09:21
@literat
Copy link
Collaborator

literat commented Jan 23, 2025

Please, consider adding a demo with this, so the end-to-end tests can test this. Thanks.

@coveralls
Copy link

coveralls commented Jan 23, 2025

Coverage Status

coverage: 79.469%. remained the same
when pulling 272ac9c on fix/ds-1664-radio-multiple-lines
into 61019bf on main.

Copy link
Contributor

@curdaj
Copy link
Contributor Author

curdaj commented Jan 24, 2025

Please, consider adding a demo with this, so the end-to-end tests can test this. Thanks.

added

@curdaj curdaj force-pushed the fix/ds-1664-radio-multiple-lines branch from 3a9c80d to 49f321b Compare January 24, 2025 09:30
@curdaj curdaj force-pushed the fix/ds-1664-radio-multiple-lines branch 2 times, most recently from 02735ee to 272ac9c Compare January 24, 2025 09:35
@curdaj curdaj force-pushed the fix/ds-1664-radio-multiple-lines branch from 272ac9c to 5ae33ca Compare January 24, 2025 12:46
@curdaj curdaj merged commit be0c466 into main Jan 24, 2025
35 checks passed
@curdaj curdaj deleted the fix/ds-1664-radio-multiple-lines branch January 24, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants