Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 TEST - Header unsafe #1869

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

🧪 TEST - Header unsafe #1869

wants to merge 21 commits into from
+4,154 −100

Conversation

pavelklibani
Copy link
Contributor

File:
packages/web-react/src/components/UNSTABLE_Header/demo/HeaderWithNavigation.tsx

  • lines: 61, 103

DropdownTrigger:
packages/web-react/src/components/Dropdown/DropdownTrigger.tsx

  • line: 29
  • Fixes the problem with duplicated classes (class, unsafe_classname in DOM), but unit tests are not working
  • Probably not problem of styleProps/UNSAFE_classnames, but with the component itself

Note

Last commit 'Testing' (d351b46) is our last work in the office and could be dropped.

pavelklibani and others added 20 commits January 16, 2025 16:19
@pavelklibani
UNSAFE classname test
ae48bf1
@crishpeen
Feat(web): Introduce UNSTABLE Header component #DS-1523
9b4e0f1
@crishpeen
Feat(web): Introduce Navigation and NavigationLink components #DS-155…
ce7f094 
…1 #DS-1530
@curdaj @crishpeen
Feat(web-react): Introduce UNSTABLE_Header #DS-1524
b64e297
@curdaj @crishpeen
Feat(web-react): Introduce Navigation #DS-1524
d88fd0f
@crishpeen
Fix(web): Rename NavigationLink component to NavigationAction
65dac3d
@crishpeen
Fix(web-react): Rename NavigationLink component to NavigationAction
fcb51bb
@crishpeen
Test: Update Homepage Screenshots
f5935df
@curdaj @crishpeen
Feat(web-react): Introduce Drawer component #DS-1580
480d7df
@curdaj @crishpeen
Feat(web): Introduce Drawer component #DS-1580
a085b4b
@crishpeen
Feat(web): Introduce alignment to Dropdown component #DS-1411
5c4d14f
@crishpeen
Feat(web-react): Introduce alignment to Dropdown component #DS-1411
0dd5e8f
@crishpeen
Feat(web-twig): Introduce alignment to Dropdown component #DS-1411
4945171
@crishpeen
Feat(web): Introduce button-unstyled helper
e73cbe7
@crishpeen
Feat(web): Introduce NavigationItem subcomponent #DS-1411
f6a347f
@crishpeen
Feat(web-react): Introduce NavigationItem subcomponent #DS-1411
03a93ea
@crishpeen
Docs(web): Showcase Header with Navigation and Dropdown #DS-1411
9d2d268
@crishpeen
Docs(web-react): Showcase Header with Navigation and Dropdown #DS-1411
0b76c7f
@crishpeen
Test(web-react): Test UNSAFE in Header
f1e5463
@pavelklibani
Testing
d351b46
@pavelklibani pavelklibani requested a review from literat January 24, 2025 09:07
@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit cae240a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/679382073bd1e600082268df
😎 Deploy Preview https://deploy-preview-1869--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit cae240a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/679382071b07a9000852e66b
😎 Deploy Preview https://deploy-preview-1869--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani changed the title TEST - Header unsafe 🧪 TEST - Header unsafe Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat Awaiting requested review from literat literat is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna will be requested when the pull request is marked ready for review adamkudrna is a code owner

@crishpeen crishpeen Awaiting requested review from crishpeen crishpeen will be requested when the pull request is marked ready for review crishpeen is a code owner

@katerinarehorkova katerinarehorkova Awaiting requested review from katerinarehorkova katerinarehorkova will be requested when the pull request is marked ready for review katerinarehorkova is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj will be requested when the pull request is marked ready for review curdaj is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelklibani @crishpeen @curdaj @literat