-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web-twig]: Re-enable twig development #1871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
maintenance
Changes to the build process or auxilary tools and libraries or other maintenance
label
Jan 24, 2025
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
force-pushed
the
chore/web-twig-docker
branch
from
January 24, 2025 16:48
5cc42ed
to
c047411
Compare
literat
requested review from
adamkudrna,
crishpeen,
pavelklibani,
katerinarehorkova and
a team
as code owners
January 24, 2025 16:58
pavelklibani
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working for me, thank you!
literat
force-pushed
the
chore/web-twig-docker
branch
from
January 28, 2025 11:42
dafae39
to
5e9d274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
Changes to the build process or auxilary tools and libraries or other maintenance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Works for me. Please, try it and add screenshots of your problems into the comments.
I have started with a clean slate.
make pristine
make install
docker image rm -f ...
packages/web-twig
make build
make start
retry with
make encore-build
Issue reference
https://jira.almacareer.tech/browse/DS-1571