Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web-react): Introduce variants to NavigationAction #DS-1672 #1898

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Jan 31, 2025

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Jan 31, 2025
@curdaj curdaj changed the base branch from main to feat/DS-1672-navigation-action-pill January 31, 2025 10:21
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 5cba4fd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67a1d0928713880008316bcb

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 5cba4fd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67a1d09246ee9a00084990e8
😎 Deploy Preview https://deploy-preview-1898--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@curdaj curdaj force-pushed the feat/DS-1672-navigation-action-pill-react branch from c591f00 to 57d3953 Compare February 3, 2025 09:28
@curdaj curdaj added the run-visual-tests Runs visual regression testing on this PR label Feb 3, 2025
@curdaj curdaj marked this pull request as ready for review February 3, 2025 09:29
@curdaj curdaj force-pushed the feat/DS-1672-navigation-action-pill-react branch from 57d3953 to 5cba4fd Compare February 4, 2025 08:32
@curdaj curdaj merged commit dd4cc14 into feat/DS-1672-navigation-action-pill Feb 4, 2025
23 checks passed
@curdaj curdaj deleted the feat/DS-1672-navigation-action-pill-react branch February 4, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants