-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LilyGo T-Display-S3 Support #20
Conversation
@motorina0 @blackcoffeexbt @arcbtc @fiatjaf @dni Just a heads up... the release looks massive, but that's due to upgrading the TFT_eSPI library to support the newer display types. You'll notice that the NSD changes themselves are relatively small compared to my previous PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Needs testing on a physical device
damn, nsd is still not uppgraded to the new hardware installer... #16 |
So can i use a regular t-display as it scales? Misplaced my S3 - ordering a new one |
Yes, however if the PIN numbers don't match the T-Display S3 or TTGO, you might need to add a new device type and find the right device in TFT-eSPI. Don't have a T-Display to test myself. |
Minor challenge, it seems that T-Display-S3 can be either RGB or BGR meaning that the blue and reds displayed on the screen may be inverted. For this release you can change the colour order in the user select file (just comment our the old one and uncomment the new one), for the next PR which has BLE support, I'll look to add a menu item to allow the user to switch colour order on device. Will need a new helper function to switch at runtime. |
Release Notes for LNbits NSD (LilyGo T-Display-S3 Support)
Added
Support for LilyGo T-Display-S3
UI Improvements
Updated