fix: icon button testid (#493)

lob · May 6, 2024 · 320c159 · 320c159
1 parent 2975ba0
commit 320c159
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## v2.0.53
+
+- Fixes the `IconButton` test ID
+
 ## v2.0.52
 
 - Add new icons for the `Icon` component

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lob/ui-components",
-  "version": "2.0.52",
+  "version": "2.0.53",
   "engines": {
     "node": ">=20.2.0",
     "npm": ">=10.2.0"

diff --git a/src/components/DataTable/DataTable.vue b/src/components/DataTable/DataTable.vue
@@ -34,7 +34,8 @@
         : undefined
     "
   >
-    <template v-if="!loading" #empty>
+    <!-- For some reason, if this is not explicit it fails. -->
+    <template v-if="loading !== true" #empty>
       <Alert v-if="error" variant="error">{{ error }}</Alert>
       <Alert v-else variant="info">No results</Alert>
     </template>

diff --git a/src/components/IconButton/IconButton.vue b/src/components/IconButton/IconButton.vue
@@ -10,7 +10,9 @@
       v-bind="!to ? $attrs : undefined"
       :class="`uic-icon-button size-${size} color-${color} variant-${variant}`"
       :disabled="disabled"
-      :data-testid="$attrs['data-testid'] ?? 'uic-icon-button'"
+      :data-testid="
+        !to ? $attrs['data-testid'] ?? 'uic-icon-button' : undefined
+      "
       @click="$emit('click', $event)"
     >
       <Icon :icon="icon" :size="iconSize" />