Add new s3 backend endpoints option #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
requested changes
Jan 30, 2024
lakkeger
force-pushed
the
tf_s3_backend_endpoints
branch
3 times, most recently
from
0f3dff1 to
7f74180
Compare
lakkeger
force-pushed
the
tf_s3_backend_endpoints
branch
from
7f74180 to
70b72da
Compare
alexrashed
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With v1.6 TF started to introduce a new format for s3 backend's endpoint option to be uniform with the AWS provider.
All previous options had been marked deprecated and who knows which version will remove it completely.
Docs: https://developer.hashicorp.com/terraform/language/settings/backends/s3#overriding-aws-api-endpoints
GH Issue: hashicorp/terraform#30492
As it's a relatively new option we need to introduce backward compatibility for legacy users.
Changes