fix list handling #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Thanks a lot, @wisefool769 for taking the initiative and filing the PR! The changes are looking good!
But it would be really great if we could verify that this works (and protect us from future regressions) by extending an existing test or writing a new test for this behavior?
Currently, all tests are collected in test_apply.py...
|
@alexrashed modified an existing test and confirmed that it catches this bug + that the changeset fixes it. note that the tests don't actually run with python < 3.12 because they use a newly added option in |
alexrashed
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in generation of terraform config file where list literals are improperly converted to hcl
Fixes #65