Feature/user managed identity #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 21, 2018 17:28
wesyao
reviewed
Jun 26, 2018
| * `tags` - (Optional) A mapping of tags to assign to the resource. | ||
|
|
||
| ## Attributes Reference | ||
|
|
There was a problem hiding this comment.
Example is in a first section
wesyao
reviewed
Jun 26, 2018
| * `location` - (Required) The location/region where the user assigned identity is | ||
| created. | ||
|
|
||
| * `tags` - (Optional) A mapping of tags to assign to the resource. |
There was a problem hiding this comment.
Most of components don't have it. Since Tags is a common thing, not smth unique for this resource I don't think we need it.
wesyao
reviewed
Jun 26, 2018
| User Assigned Identitites can be imported using the `resource id`, e.g. | ||
|
|
||
| ```shell | ||
| terraform import azurerm_user_assigned_identity.testIdentity /subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/acceptanceTestResourceGroup1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/testIdentity |
There was a problem hiding this comment.
i think it needs to be more clear what i need to fill in here
There was a problem hiding this comment.
eg: /subscriptions/<subscription_id>/resourcegroups/<resource_group_name>
There was a problem hiding this comment.
What I used is common across Terraform docs, don't think we should change their format.
wesyao
reviewed
Jun 26, 2018
| @@ -441,7 +441,9 @@ resource "azurerm_virtual_machine" "test" { | |||
|
|
|||
| `identity` supports the following: | |||
|
|
|||
| * `type` - (Required) Specifies the identity type of the virtual machine. The only allowable value is `SystemAssigned`. To enable Managed Service Identity the virtual machine extension "ManagedIdentityExtensionForWindows" or "ManagedIdentityExtensionForLinux" must also be added to the virtual machine. The Principal ID can be retrieved after the virtual machine has been created, e.g. | |||
| * `type` - (Required) Specifies the identity type of the virtual machine. Allowable values are `SystemAssigned` and `UserAssigned`. To enable Managed Service Identity the virtual machine extension "ManagedIdentityExtensionForWindows" or "ManagedIdentityExtensionForLinux" must also be added to the virtual machine. For the `SystemAssigned` identity the Principal ID can be retrieved after the virtual machine has been created. | |||
There was a problem hiding this comment.
what's the difference betweenSystemAssigned and UserAssigned. it would be helpful to know what the difference is
There was a problem hiding this comment.
Added a link to MS docs.
wesyao
reviewed
Jun 26, 2018
| @@ -274,7 +274,9 @@ The following arguments are supported: | |||
|
|
|||
| `identity` supports the following: | |||
|
|
|||
| * `type` - (Required) Specifies the identity type to be assigned to the scale set. The only allowable value is `SystemAssigned`. To enable Managed Service Identity (MSI) on all machines in the scale set, an extension with the type "ManagedIdentityExtensionForWindows" or "ManagedIdentityExtensionForLinux" must also be added. The scale set's Service Principal ID (SPN) can be retrieved after the scale set has been created. | |||
| * `type` - (Required) Specifies the identity type to be assigned to the scale set. Allowable values are `SystemAssigned` and `UserAssigned`. To enable Managed Service Identity (MSI) on all machines in the scale set, an extension with the type "ManagedIdentityExtensionForWindows" or "ManagedIdentityExtensionForLinux" must also be added. For the `SystemAssigned` identity the scale set's Service Principal ID (SPN) can be retrieved after the scale set has been created. | |||
There was a problem hiding this comment.
Added a link to MS docs.
wesyao
approved these changes
Jun 26, 2018
logachev
pushed a commit
that referenced
this pull request
Jun 26, 2018
added 2 commits
June 29, 2018 12:07
logachev
pushed a commit
that referenced
this pull request
Jun 29, 2018
``` acctests azurerm TestAccAzureRMUserAssignedIdentity_ === RUN TestAccAzureRMUserAssignedIdentity_importBasic --- PASS: TestAccAzureRMUserAssignedIdentity_importBasic (80.67s) === RUN TestAccAzureRMUserAssignedIdentity_basic --- PASS: TestAccAzureRMUserAssignedIdentity_basic (78.45s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 159.156s ```
logachev
pushed a commit
that referenced
this pull request
Nov 10, 2019
logachev
pushed a commit
that referenced
this pull request
Jul 31, 2020
…validation Update path validation for api management api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal PR to gather feedback