Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always check stress in is_converged() if present in results #168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Always check stress in is_converged() if present in results #168

wants to merge 2 commits into from

Conversation

ikowalec
Copy link
Collaborator

Formerly, if 'forces' and 'stress' were present, 'forces' would take priority and 'stress' was not checked.

Now both properties are checked against fmax if available in Atoms.calc.results

@logsdail
Copy link
Owner

There seems to be a new weird error relating to the requirements file in the CI, which I don’t think you’ve touched?

@ikowalec
Copy link
Collaborator Author

There seems to be a new weird error relating to the requirements file in the CI, which I don’t think you’ve touched?

No, I have not. The tests are passing locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikowalec @logsdail