-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable scaled positions #178
base: main
Are you sure you want to change the base?
Conversation
Force the function to use Cartesian coordinates
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 89.71% 89.73% +0.02%
==========================================
Files 85 85
Lines 3703 3712 +9
==========================================
+ Hits 3322 3331 +9
Misses 381 381
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mainly fine - just two queries to consider from me.
@GaryLZW is this now complete? Can we close? |
Disable the use of scaled positions.
Add a check for forces.
atom_frac 0.4357165014942807 0.1285670137858732 0.7071548182024310 O
When replacing
atom_frac
withempty
, fhi-aims will treat the coordinates as Cartesian coordinates.This is incorrect and could cause error like this.