Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable scaled positions #178

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

GaryLZW
Copy link
Collaborator

@GaryLZW GaryLZW commented Aug 15, 2024

Disable the use of scaled positions.
Add a check for forces.

atom_frac 0.4357165014942807 0.1285670137858732 0.7071548182024310 O
When replacing atom_frac with empty, fhi-aims will treat the coordinates as Cartesian coordinates.
This is incorrect and could cause error like this.

*** Proc 570 in check_for_close_encounters: * ERROR: atoms 32 and 43 too close to each other!

GaryLZW and others added 2 commits August 15, 2024 11:37
Force the function to use Cartesian coordinates
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (c10c905) to head (a7bef24).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   89.71%   89.73%   +0.02%     
==========================================
  Files          85       85              
  Lines        3703     3712       +9     
==========================================
+ Hits         3322     3331       +9     
  Misses        381      381              
Flag Coverage Δ
unittests 89.73% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GaryLZW GaryLZW marked this pull request as ready for review August 15, 2024 11:41
Copy link
Owner

@logsdail logsdail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mainly fine - just two queries to consider from me.

carmm/analyse/counterpoise_onepot.py Outdated Show resolved Hide resolved
carmm/analyse/counterpoise_onepot.py Show resolved Hide resolved
@logsdail
Copy link
Owner

logsdail commented Oct 2, 2024

@GaryLZW is this now complete? Can we close?

@GaryLZW
Copy link
Collaborator Author

GaryLZW commented Oct 3, 2024

@GaryLZW is this now complete? Can we close?

Hi @logsdail. It is complete. Could you approve this? I will merge and close this pull request.

@GaryLZW GaryLZW requested a review from AkashHiregange October 4, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants