Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@request_tokens and @requests appears unused #139

Open
dyladan opened this issue Jul 7, 2023 · 0 comments
Open

@request_tokens and @requests appears unused #139

dyladan opened this issue Jul 7, 2023 · 0 comments

Comments

@dyladan
Copy link

dyladan commented Jul 7, 2023

To be honest I'm not sure if this is a documentation issue, a bug, or just tech debt left over.

The instance variable @request_tokens is documented as a way to control the number of open requests, but I can't see anywhere in the plugin code or the HTTP mixin code that actually uses it for anything. The commit (899196f) that authored this variable does appear to actually have used it at one point (899196f#diff-ade3d8629809fb4e534347d2d6fb03b65b0b0d852fcce1ef3c9fa4090cda1562R101).

Similarly, the instance variable @requests is also apparently unused. It also appears to have been used in the commit that originally authored it (287dbf5).

I am using this plugin as an example for another plugin that I'm developing, but this part really confused me. Are these variables actually used in some hidden way, or are they just left over from a previous version of the plugin? If they're left over tech debt I'm happy to make a PR to remove them so others aren't confused in the future.

@dyladan dyladan changed the title request_tokens appears to do nothing @request_tokens and @requests appears unused Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant