-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow log in with 2fa #12
base: master
Are you sure you want to change the base?
Conversation
Hello. Are you planning to merge this to the master? Will this resolve the 2FA login? |
It would resolve it but the owner of this repo has been inactive for a few years now. If you want you can install this package with this change like this:
|
Oh wow, thanks. It worked.
So am I correct, I have to always type the current code for this to work? Can't this be more automated so it can work in the background? |
You can use a package that can generate the TOTP automatically, e.g. https://pypi.org/project/pyotp/
Getting your old If Degiro doesn't show the seed as string (32 alphanumeric characters) you'll have to extract it from the QR code. I hope I don't need to explain the security implication of doing all this. EDIT: But I guess doing this is still better than not using 2FA at all... |
I just figured it out too. Yeah, security implications are... "Don't get hacked" :-) And use it only on a secured machine. Yeah, but better than without 2FA. For future reference, these were my steps:
|
Issue:
Currently degrioapi does not permit log in with accounts that use Two Factor Authentication (2FA).
Solution:
If in the DeGiro.login method the user provides a TOTP code, the login is done through the TOTP Log in URL, and provides the oneTimePassword as part of the login_payload.